-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reuse LocalAuthentication context #74
Reuse LocalAuthentication context #74
Conversation
Hi @eaceto, apologies for the delay. |
Hello Rita, how are you? Thanks for replying, and sorry for not fixing that earlier. I was on holidays. Let me add this checks now in order to fix the CI errors. Thanks! |
Hi @Widcket ! All tests passed, now. If you want to perform a detailed review on the Pull Request, please let me know. |
@Widcket all changes where made, and branch was rebased to current master (due to a PR about SPM) |
Changes
Please describe both what is changing and why this is important. Include:
References
Please include relevant links supporting this change such as a:
Testing
Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If helpful, please include manual testing steps as well.
[ ] This change adds unit test coverage (or why not)
It does not include Unit Test. The Test requires UI Interaction in order to see the behavior
[X] This change has been tested on the latest version of the platform/language or why not
Tested on iOS 13.2
Checklist
[X] I have read the Auth0 general contribution guidelines
[X] I have read the Auth0 Code of Conduct
[X] All existing and new tests complete without errors