Skip to content

Commit

Permalink
chore: fix linter warnings (#767)
Browse files Browse the repository at this point in the history
### Changes

<!--
  Please outline the changes made in this pull request.
-->

This PR fixes a number of linter warnings that are breaking pull
requests. It also pins certain development dependencies that have been
prone to introducing these types of breaking changes in their minor
releases to help avoid future breaks.

### References

<!--
  Link to any associated issues, pull requests, or other resources.
-->

### Testing

<!--
  Tests must be added for new functionality.
  Existing tests should complete without errors.
  100% test coverage is required.
-->

### Contributor Checklist

- [x] I agree to adhere to the [Auth0 General Contribution
Guidelines](https://github.com/auth0/open-source-template/blob/master/GENERAL-CONTRIBUTING.md).
- [x] I agree to uphold the [Auth0 Code of
Conduct](https://github.com/auth0/open-source-template/blob/master/CODE-OF-CONDUCT.md).
  • Loading branch information
evansims committed Jul 12, 2024
1 parent 318fca1 commit d263216
Show file tree
Hide file tree
Showing 4 changed files with 22 additions and 19 deletions.
1 change: 1 addition & 0 deletions .php-cs-fixer.dist.php
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
<?php

return (new PhpCsFixer\Config())
->setParallelConfig(PhpCsFixer\Runner\Parallel\ParallelConfigFactory::detect())
->setRiskyAllowed(true)
->setRules([
'array_indentation' => true,
Expand Down
22 changes: 11 additions & 11 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,19 +39,19 @@
"psr/http-message-implementation": "^1"
},
"require-dev": {
"ergebnis/composer-normalize": "^2",
"friendsofphp/php-cs-fixer": "^3",
"mockery/mockery": "^1",
"pestphp/pest": "^2",
"phpstan/phpstan": "^1",
"phpstan/phpstan-strict-rules": "^1",
"psr-mock/http": "^1",
"rector/rector": "0.17.6",
"spatie/ray": "^1",
"ergebnis/composer-normalize": "~2.43.0",
"friendsofphp/php-cs-fixer": "~3.59.0",
"mockery/mockery": "~1.6.0",
"pestphp/pest": "~2.34.0",
"phpstan/phpstan": "~1.11.0",
"phpstan/phpstan-strict-rules": "~1.6.0",
"psr-mock/http": "~1.0.0",
"rector/rector": "~0.17.0",
"spatie/ray": "~1.41.0",
"symfony/cache": "^4 || ^5 || ^6",
"symfony/event-dispatcher": "^4 || ^5 || ^6",
"vimeo/psalm": "^5",
"wikimedia/composer-merge-plugin": "^2"
"vimeo/psalm": "~5.25.0",
"wikimedia/composer-merge-plugin": "~2.1.0"
},
"suggest": {
"psr/cache-implementation": "(PSR-6 Cache) Improve performance by avoiding making redundant network requests.",
Expand Down
1 change: 1 addition & 0 deletions phpstan.neon.dist
Original file line number Diff line number Diff line change
Expand Up @@ -48,3 +48,4 @@ parameters:
path: src\Utility\HttpRequest.php

reportUnmatchedIgnoredErrors: false
treatPhpDocTypesAsCertain: false
17 changes: 9 additions & 8 deletions rector.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@
use Rector\CodeQuality\Rector\ClassMethod\{InlineArrayReturnAssignRector,
NarrowUnionTypeDocRector,
OptionalParametersAfterRequiredRector,
ReturnTypeFromStrictScalarReturnExprRector};
// ReturnTypeFromStrictScalarReturnExprRector
};
use Rector\CodeQuality\Rector\Concat\JoinStringConcatRector;
use Rector\CodeQuality\Rector\Empty_\SimplifyEmptyCheckOnEmptyArrayRector;
use Rector\CodeQuality\Rector\Equal\UseIdenticalOverEqualWithSameTypeRector;
Expand Down Expand Up @@ -207,10 +208,10 @@
AddReturnTypeDeclarationBasedOnParentClassMethodRector,
AddVoidReturnTypeWhereNoReturnRector,
ArrayShapeFromConstantArrayReturnRector,
ParamAnnotationIncorrectNullableRector,
// ParamAnnotationIncorrectNullableRector,
ParamTypeByMethodCallTypeRector,
ParamTypeByParentCallTypeRector,
ReturnAnnotationIncorrectNullableRector,
// ReturnAnnotationIncorrectNullableRector,
ReturnNeverTypeRector,
ReturnTypeFromReturnDirectArrayRector,
ReturnTypeFromReturnNewRector,
Expand All @@ -220,7 +221,7 @@
ReturnTypeFromStrictNewArrayRector,
ReturnTypeFromStrictTypedCallRector,
ReturnTypeFromStrictTypedPropertyRector};
use Rector\TypeDeclaration\Rector\Closure\AddClosureReturnTypeRector;
// use Rector\TypeDeclaration\Rector\Closure\AddClosureReturnTypeRector;
use Rector\TypeDeclaration\Rector\Empty_\EmptyOnNullableObjectToInstanceOfRector;
use Rector\TypeDeclaration\Rector\FunctionLike\{AddParamTypeSplFixedArrayRector,
AddReturnTypeDeclarationFromYieldsRector};
Expand Down Expand Up @@ -336,7 +337,7 @@
// ActionInjectionToConstructorInjectionRector::class,
AddArrayDefaultToArrayPropertyRector::class,
AddArrowFunctionReturnTypeRector::class,
AddClosureReturnTypeRector::class,
// AddClosureReturnTypeRector::class,
// AddFalseDefaultToBoolPropertyRector::class,
AddMethodCallBasedStrictParamTypeRector::class,
AddParamBasedOnParentClassMethodRector::class,
Expand Down Expand Up @@ -412,7 +413,7 @@
// NormalizeNamespaceByPSR4ComposerAutoloadRector::class,
NullableCompareToNullRector::class,
OptionalParametersAfterRequiredRector::class,
ParamAnnotationIncorrectNullableRector::class,
// ParamAnnotationIncorrectNullableRector::class,
ParamTypeByMethodCallTypeRector::class,
ParamTypeByParentCallTypeRector::class,
ParamTypeFromStrictTypedPropertyRector::class,
Expand Down Expand Up @@ -466,7 +467,7 @@
RenameForeachValueVariableToMatchExprVariableRector::class,
RenameForeachValueVariableToMatchMethodCallReturnTypeRector::class,
ReplaceMultipleBooleanNotRector::class,
ReturnAnnotationIncorrectNullableRector::class,
// ReturnAnnotationIncorrectNullableRector::class,
// ReturnBinaryAndToEarlyReturnRector::class,
ReturnBinaryOrToEarlyReturnRector::class,
ReturnEarlyIfVariableRector::class,
Expand All @@ -477,7 +478,7 @@
ReturnTypeFromStrictConstantReturnRector::class,
ReturnTypeFromStrictNativeCallRector::class,
ReturnTypeFromStrictNewArrayRector::class,
ReturnTypeFromStrictScalarReturnExprRector::class,
// ReturnTypeFromStrictScalarReturnExprRector::class,
ReturnTypeFromStrictTernaryRector::class,
ReturnTypeFromStrictTypedCallRector::class,
ReturnTypeFromStrictTypedPropertyRector::class,
Expand Down

0 comments on commit d263216

Please sign in to comment.