Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructured tests and fixed hhvm build #164

Merged
merged 3 commits into from
Jun 22, 2017
Merged

Restructured tests and fixed hhvm build #164

merged 3 commits into from
Jun 22, 2017

Conversation

Nyholm
Copy link
Contributor

@Nyholm Nyholm commented Apr 9, 2017

No description provided.

@Nyholm
Copy link
Contributor Author

Nyholm commented May 4, 2017

What can I do to help reviewing this?

@cocojoe cocojoe added this to the v5-Next milestone Jun 22, 2017
@cocojoe
Copy link
Member

cocojoe commented Jun 22, 2017 •
edited
Loading

Please rebase your commits, dont mind informative ones but typo doesn't really need an entry. git rebase -i @~2 --preserve-merges in the branch.

@Nyholm
Copy link
Contributor Author

Nyholm commented Jun 22, 2017

I rebased the PR and squashed the commits.

@Nyholm
Copy link
Contributor Author

Nyholm commented Jun 22, 2017

#158 will fix the HHVM build error.

@cocojoe
Copy link
Member

cocojoe commented Jun 22, 2017

Is it a small fix? if so can it be moved into a new PR? The HTTP PR is for v6 and this is v5, just be nice to see all green checks :) Thx

@Nyholm
Copy link
Contributor Author

Nyholm commented Jun 22, 2017

There you go.
Thank you for reviewing this.

@cocojoe cocojoe self-requested a review June 22, 2017 19:46
@cocojoe cocojoe changed the base branch from master to 5.x.x-dev June 22, 2017 19:46
cocojoe
cocojoe approved these changes Jun 22, 2017
View reviewed changes
Copy link
Member

@cocojoe cocojoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed with @glena, looks fine and good to fix hhvm as well.

@cocojoe cocojoe changed the title Moved around the tests to reflect folder structure in src Restructured tests and fixed hhvm build Jun 22, 2017
@cocojoe cocojoe merged commit fb7758d into auth0:5.x.x-dev Jun 22, 2017
@Nyholm
Copy link
Contributor Author

Nyholm commented Jun 22, 2017

Thank you for merging

@Nyholm Nyholm deleted the structure-tests branch June 22, 2017 20:06
@cocojoe cocojoe modified the milestones: 5.0.4, v5-Next Jun 26, 2017
@cocojoe cocojoe mentioned this pull request Jun 26, 2017
Merged
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cocojoe cocojoe cocojoe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0.4
Development

Successfully merging this pull request may close these issues.
2 participants
@Nyholm @cocojoe