Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding tests for state handler; correcting storage method used #228

Merged
merged 1 commit into from
Feb 26, 2018

Conversation

joshcanhelp
Copy link
Contributor

Tests are self-explanatory.

@cocojoe - It looks like you created a store method and then didn't use it so I made that change.

@joshcanhelp joshcanhelp added this to the v5-Next milestone Feb 23, 2018
@lbalmaceda lbalmaceda self-requested a review February 24, 2018 13:18
Copy link
Contributor

@lbalmaceda lbalmaceda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Member

@cocojoe cocojoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Tests

@joshcanhelp joshcanhelp merged commit 721c2c8 into 5.x.x-dev Feb 26, 2018
@joshcanhelp joshcanhelp deleted the added-state-handler-tests branch February 26, 2018 15:54
@joshcanhelp joshcanhelp mentioned this pull request Mar 1, 2018
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants