Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ResourceServices::getAll() #236

Merged
merged 2 commits into from
Mar 21, 2018

Conversation

joshcanhelp
Copy link
Contributor

Also adds tests for the whole ResourceServices class

Fixes #200

@joshcanhelp joshcanhelp self-assigned this Mar 20, 2018
@joshcanhelp joshcanhelp added this to the 5.1.1 milestone Mar 20, 2018
@cocojoe
Copy link
Member

cocojoe commented Mar 21, 2018

Tests++

Copy link
Member

@cocojoe cocojoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM also Tests 😄

@joshcanhelp joshcanhelp merged commit 850e0fe into 5.x.x-dev Mar 21, 2018
@joshcanhelp joshcanhelp deleted the add-resource-servers-getall branch March 21, 2018 14:54
@joshcanhelp joshcanhelp mentioned this pull request Apr 3, 2018
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants