Pagination, additional parameters, and tests for the Connections endpoint #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will replace #247 |
joshcanhelp
force-pushed
the
add-connections-pagination-tests
branch
from
5af41c7
to
13143d2
Compare
Add pagination to getAll method via page and per_page parameters. Add application type to getAll method via app_type parameter and app_type constants. Change apiClient fluent methods to explicit. Add validation for required 'name' parameter in create method. Add docblocks throughout Clients. Add additional testing for Clients and BasicCrudTest.
joshcanhelp
force-pushed
the
add-connections-pagination-tests
branch
from
13143d2
to
f404503
Compare
…r test tweak for accuracy
lbalmaceda
reviewed
Jun 7, 2018
| $add_params = [] | ||
| ) { | ||
| // Set additional parameters first so they are over-written by function parameters. | ||
| $params = is_array($add_params) ? $add_params : []; |
There was a problem hiding this comment.
again. Is array? shouldn't $param be a dictionary structure?
There was a problem hiding this comment.
Yes, which is == array in PHP ... no special data structure for that
| { | ||
| return $this->apiClient->patch() | ||
| ->connections($id) | ||
| ->withHeader(new ContentType('application/json')) |
There was a problem hiding this comment.
This one is now missing. Was missing from #256 too. Are you covering this somewhere else?
There was a problem hiding this comment.
method('patch') adds that header automatically
src/API/Management/Connections.php
Outdated
| * @return mixed | ||
| * Delete a specific User for a Connection. | ||
| * | ||
| * @param string $id - Connection ID (currently only database connections are supported). |
There was a problem hiding this comment.
AKA auth0 strategies. Is there another way to rephrase this database only warning?
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar implementation as #256