Allow $page to be null for Clients so pagination is not triggered #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbalmaceda
approved these changes
Jun 5, 2018
| @@ -20,7 +20,7 @@ class Clients extends GenericResource | |||
| * | |||
| * @param null|string|array $fields - Fields to include or exclude from the result. | |||
| * @param null|boolean $include_fields - True to include $fields, false to exclude $fields. | |||
| * @param integer $page - Page number to get, zero-based. | |||
| * @param null|integer $page - Page number to get, zero-based. | |||
There was a problem hiding this comment.
Null to not request pagination
There was a problem hiding this comment.
@lbalmaceda - That's only for legacy clients, correct? We don't want to force pagination but don't we also want to encourage folks to use it? Seems confusing to add that with or without a note about legacy clients.
There was a problem hiding this comment.
@joshcanhelp you're right :)
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.