Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix formatting, code standards scan #274

Merged
merged 1 commit into from
Jul 11, 2018
Merged

Fix formatting, code standards scan #274

merged 1 commit into from
Jul 11, 2018

Conversation

joshcanhelp
Copy link
Contributor

  • Fix docblocks for phpcs scan
  • Add array type hinting

@joshcanhelp joshcanhelp added this to the v5-Next milestone Jul 5, 2018
@joshcanhelp joshcanhelp added the WIP label Jul 5, 2018
cocojoe
cocojoe approved these changes Jul 11, 2018
View reviewed changes
Copy link
Member

@cocojoe cocojoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshcanhelp joshcanhelp merged commit 24ee154 into master Jul 11, 2018
@joshcanhelp joshcanhelp deleted the fix-formatting branch July 11, 2018 20:13
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cocojoe cocojoe cocojoe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@joshcanhelp @cocojoe