Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config keys for session base name and cookie expires #279

Merged
merged 1 commit into from
Aug 9, 2018

Conversation

joshcanhelp
Copy link
Contributor

This PR adds the ability to change the base name for the session key as well as the session cookie expires:

  • Add a session_base_name key to the config array passed when instantiating Auth0 to change the session key base name used.
  • Add a session_cookie_expires key to the config array passed when instantiating Auth0 to change the session cookie expires time. Cannot remove that from the default or else session cookies would be shorter than expected for anyone using the default.
  • Moved the SessionStore::initSession() call out of the SessionStore constructor so it happens later in the execution, allowing for apps that start their own sessions to do that more easily.

Closes #215
Closes #273

@joshcanhelp joshcanhelp added this to the v5-Next milestone Aug 7, 2018
Copy link
Member

@cocojoe cocojoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshcanhelp joshcanhelp merged commit bca81a1 into master Aug 9, 2018
@joshcanhelp joshcanhelp deleted the change-session-store-handling branch August 9, 2018 15:20
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants