Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix documentation for Auth0 constructor options #298

Merged
merged 1 commit into from
Oct 23, 2018
Merged

Fix documentation for Auth0 constructor options #298

merged 1 commit into from
Oct 23, 2018

Conversation

ivastly
Copy link

@ivastly ivastly commented Oct 23, 2018

No description provided.

joshcanhelp
joshcanhelp suggested changes Oct 23, 2018
View reviewed changes
Copy link
Contributor

@joshcanhelp joshcanhelp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much @biganfa! There are actually a few more config options that could be added while you're in there. Would you add the remaining ones here?

secret_base64_encoded
scope
id_token_alg
id_token_aud
id_token_iss

@ivastly
Copy link
Author

ivastly commented Oct 23, 2018

@joshcanhelp thank you for your reply. Unfortunetely, I don't completely understand the meaning of remaining parameters either 😕

joshcanhelp
joshcanhelp approved these changes Oct 23, 2018
View reviewed changes
Copy link
Contributor

@joshcanhelp joshcanhelp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's an improvement none-the-less ... thank you @biganfa!

@joshcanhelp joshcanhelp added this to the v5-Next milestone Oct 23, 2018
@joshcanhelp joshcanhelp merged commit aac05cf into auth0:master Oct 23, 2018
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joshcanhelp joshcanhelp joshcanhelp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.3.1
Development

Successfully merging this pull request may close these issues.
3 participants
@ivastly @joshcanhelp @aterkin