Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test suite improvements #313

Merged
merged 1 commit into from
Jan 9, 2019
Merged

Test suite improvements #313

merged 1 commit into from
Jan 9, 2019

Conversation

joshcanhelp
Copy link
Contributor

@joshcanhelp joshcanhelp commented Jan 8, 2019 •
edited
Loading

Minor improvements to the API test suite on the road to mocked API tests:

  • Remove ApiTests::getEnvStatic() (use ApiTests::getEnv())
  • Remove ApiTests::getTokenStatic() (use ApiTests::getToken())
  • Remove ApiTests::getApiStatic() (use ApiTests::getApi())
  • Swapped methods out through the tests.

@joshcanhelp joshcanhelp added this to the v5-Next-Minor milestone Jan 8, 2019
@joshcanhelp joshcanhelp merged commit 08ccbaf into master Jan 9, 2019
@joshcanhelp joshcanhelp deleted the change-connections-testing branch January 9, 2019 00:31
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@luisrudge luisrudge luisrudge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@joshcanhelp @luisrudge