Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Auth0-Forwarded-For header for RO grant #320

Merged
merged 5 commits into from
Feb 19, 2019
Merged

Add Auth0-Forwarded-For header for RO grant #320

merged 5 commits into from
Feb 19, 2019

Conversation

joshcanhelp
Copy link
Contributor

@joshcanhelp joshcanhelp commented Feb 13, 2019 •
edited
Loading

Changes

  • Add an Auth0-Forwarded-For header when an IP address parameter or auth0_forwarded_for option is passed
  • Add ForwardedFor header class
  • Add tests for Authentication::login_with_default_directory() method
  • Refactor MockApi to add MockManagementApi and MockAuthenticationApi
  • Reorganize Authentication API test suite into more clear test groups and fixed the namespace
  • Fix minor leftover feedback from Add Telemetry to Generated URLs; Improve API Telemetry #319 (commit)

References

Docs page on forwarding IP addresses

Closes #208

Testing

Other testing changes:

  • Authentication API mocking
  • Better Authentication API test organization
  • Added additional test coverage for RO login methods

@joshcanhelp joshcanhelp added this to the v5-Next-Minor milestone Feb 13, 2019
@joshcanhelp joshcanhelp changed the title [WIP] Add Auth0-Forwarded-For header for RO grant Add Auth0-Forwarded-For header for RO grant Feb 14, 2019
@joshcanhelp joshcanhelp merged commit 368e8dc into master Feb 19, 2019
@joshcanhelp joshcanhelp deleted the add-forwarded-for-to-ro branch February 19, 2019 21:00
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@damieng damieng damieng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.4.0
Development

Successfully merging this pull request may close these issues.

Feature Request: Support sending auth0-forwarded-for header
2 participants
@joshcanhelp @damieng