Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Authentication::refresh_token() method #335

Merged
merged 5 commits into from
Apr 30, 2019
Merged

Add Authentication::refresh_token() method #335

merged 5 commits into from
Apr 30, 2019

Conversation

joshcanhelp
Copy link
Contributor

@joshcanhelp joshcanhelp commented Apr 30, 2019 •
edited
Loading

Changes

Add \Auth0\SDK\API\Authentication::refresh_token() method and change \Auth0\SDK\Auth0::renewTokens() to use it.

Testing

  • This change adds test coverage
  • This change has been tested on PHP 7.1.27

Checklist

  • All existing and new tests complete without errors.
  • The correct base branch is being used.

@joshcanhelp joshcanhelp added this to the 5.5.0 milestone Apr 30, 2019
@joshcanhelp joshcanhelp requested review from a team and removed request for a team April 30, 2019 19:24
@joshcanhelp joshcanhelp marked this pull request as ready for review April 30, 2019 19:56
@joshcanhelp joshcanhelp requested a review from a team April 30, 2019 19:56
@joshcanhelp joshcanhelp changed the title Add failing tests for new refresh_token method Add Authentication::refresh_token() method Apr 30, 2019
@joshcanhelp joshcanhelp merged commit a5d0d17 into master Apr 30, 2019
@joshcanhelp joshcanhelp deleted the add-refresh-token-method branch April 30, 2019 20:22
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@damieng damieng damieng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@joshcanhelp @damieng