Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing Users test and switch to mocked calls. #336

Merged
merged 1 commit into from
May 29, 2019

Conversation

joshcanhelp
Copy link
Contributor

Changes

  • Adds missing Users test
  • Switches all testing to mocked API calls

Testing

  • This change adds test coverage

@joshcanhelp joshcanhelp requested a review from a team May 28, 2019 21:27
@joshcanhelp joshcanhelp added this to the 5.5.0 milestone May 28, 2019
$exception_message = $e->getMessage();
}

$this->assertContains( 'Missing required "email" field', $exception_message );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these messages triggered from your SDK or the real server?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SDK

@joshcanhelp joshcanhelp merged commit 46ecdba into master May 29, 2019
@joshcanhelp joshcanhelp deleted the add-user-permissions-roles-eps branch May 29, 2019 16:14
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants