Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all Management API Roles endpoints #337

Merged
merged 9 commits into from
Jun 3, 2019
Merged

Conversation

joshcanhelp
Copy link
Contributor

@joshcanhelp joshcanhelp commented May 29, 2019

Changes

  • Add Roles endpoints with tests
  • Fix test suite missing tests

References

Management API Roles docs

Testing

Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

  • This change adds test coverage
  • This change has been tested on the latest version of PHP

Checklist

  • All existing and new tests complete without errors.
  • The correct base branch is being used.

@joshcanhelp joshcanhelp requested a review from a team May 29, 2019 17:27
@joshcanhelp joshcanhelp added this to the 5.5.0 milestone May 29, 2019
@joshcanhelp joshcanhelp changed the title Add roles endpoints Add Management API Roles endpoints May 31, 2019
@joshcanhelp joshcanhelp changed the title Add Management API Roles endpoints Add all Management API Roles endpoints May 31, 2019
Copy link

@jbauth0 jbauth0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just little nit picky comments. fwiw - :shipit:

src/API/Management/GenericResource.php Show resolved Hide resolved
src/API/Management/Roles.php Outdated Show resolved Hide resolved
src/API/Management/Roles.php Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Jun 3, 2019

Codecov Report

Merging #337 into master will increase coverage by 11.68%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #337       +/-   ##
============================================
+ Coverage     66.21%   77.9%   +11.68%     
- Complexity      470     499       +29     
============================================
  Files            39      42        +3     
  Lines          1332    1439      +107     
============================================
+ Hits            882    1121      +239     
+ Misses          450     318      -132
Impacted Files Coverage Δ Complexity Δ
src/API/Management.php 100% <100%> (ø) 2 <0> (ø) ⬇️
src/Exception/EmptyOrInvalidParameterException.php 100% <100%> (ø) 1 <1> (?)
src/API/Management/GenericResource.php 100% <100%> (ø) 18 <16> (+16) ⬆️
src/API/Helpers/ApiClient.php 86.04% <100%> (ø) 14 <0> (ø) ⬇️
src/Exception/InvalidPermissionsArrayException.php 100% <100%> (ø) 1 <1> (?)
src/API/Management/Roles.php 100% <100%> (ø) 11 <11> (?)
src/API/Helpers/RequestBuilder.php 71.54% <0%> (+2.43%) 46% <0%> (ø) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46ecdba...ca7d20e. Read the comment docs.

@joshcanhelp joshcanhelp removed the large label Jun 3, 2019
@joshcanhelp joshcanhelp merged commit 07e28fe into master Jun 3, 2019
@joshcanhelp joshcanhelp deleted the add-roles-endpoints branch June 3, 2019 16:43
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants