Fix empty url params

[joshcanhelp]

Changes

Fixed the URL parameter building pipeline to exclude parameters with null or "" values.

References

Fixing issue brought up by #347

Testing

Failing tests for changed functionality.

• This change adds test coverage
• This change was developed in PHP 7.1.29

Checklist

• All existing and new tests complete without errors.

[stevehobbsdev]

If it's not already covered, I think an additional test with a mixture of params that have values and params that don't would be useful:

$builder = self::getUrlBuilder();
$builder->withParam('param1', 'value1');
$builder->withParam('param2', null);
$builder->withParam('param3', 'value3');

// Verify that only 1 and 3 are added
$this->assertEquals('?param1=value1&param3=value3', $builder->getParams());

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.