Fix boolean form parameters not sending as strings #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshcanhelp
commented
Aug 28, 2019
| @@ -45,7 +45,8 @@ public static function setUpBeforeClass() | |||
| /** | |||
There was a problem hiding this comment.
Whitespace only
joshcanhelp
commented
Aug 28, 2019
| @@ -45,7 +45,8 @@ public static function setUpBeforeClass() | |||
| /** | |||
There was a problem hiding this comment.
Whitespace only
joshcanhelp
commented
Aug 28, 2019
| @@ -41,7 +41,8 @@ class ClientGrantsTest extends ApiTests | |||
| * | |||
There was a problem hiding this comment.
Whitespace only
stevehobbsdev
approved these changes
Sep 2, 2019
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
In the PR linked below, we found that
trueboolean form parameters were being sent as1and ignored by the Management API (specifically the import users endpoint). URL parameters are already converted to string versions of their boolean counterparts but not form parameters. This only affects the import users endpoint, which is only sending boolean params in the PR below.References
Found in #354
Testing