Add \Auth0\SDK\Auth0::getLoginUrl() method and switch login() to use it #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevehobbsdev
previously approved these changes
Sep 24, 2019
joshcanhelp
force-pushed
the
add-build-auth-url-method
branch
from
9fa8cec
to
0ec5974
Compare
|
Waiting on a response from the author of auth0/laravel-auth0#140 before I merge this in. Want to make sure it solves that problem. |
stevehobbsdev
approved these changes
Sep 25, 2019
lbalmaceda
reviewed
Sep 25, 2019
| * | ||
| * @return string | ||
| */ | ||
| public function getLoginUrl(array $params = []) |
There was a problem hiding this comment.
Does this method need to be public?
There was a problem hiding this comment.
Yes. Solves a problem in frameworks that have their own session and redirect handling (see auth0/laravel-auth0#135)
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
\Auth0\SDK\Auth0::getLoginUrl()to expose a way to build out a login URL.\Auth0\SDK\Auth0::login()to use this method.References
auth0/laravel-auth0#140
Testing