Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated InformationHeaders methods and add types #382

Merged
merged 1 commit into from
Oct 16, 2019
Merged

Remove deprecated InformationHeaders methods and add types #382

merged 1 commit into from
Oct 16, 2019

Conversation

joshcanhelp
Copy link
Contributor

Changes

Breaking Changes:

  • Remove deprecated InformationHeaders::setEnvironment() method
  • Remove deprecated InformationHeaders:: setDependency() method
  • Remove deprecated InformationHeaders:: setDependencyData() method

Other Changes:

  • Add parameter and return types

Checklist

  • All existing and new tests complete without errors.
  • The correct base branch is being used.

@joshcanhelp joshcanhelp requested a review from a team October 16, 2019 22:08
@joshcanhelp joshcanhelp added this to the 7.0.0 milestone Oct 16, 2019
@joshcanhelp joshcanhelp merged commit 66c9035 into 7.0.0-dev Oct 16, 2019
@damieng damieng deleted the remove-deprecated-info-headers branch October 16, 2019 22:53
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@damieng damieng damieng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@joshcanhelp @damieng