Remove deprecated Authentication methods and add types #385
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Breaking Changes
Authentication
class instantiation requires aclient_id
argumentAuthentication::setApiClient()
methodAuthentication::authorize_with_ro()
methodAuthentication::authorize_with_accesstoken()
methodAuthentication::impersonate()
methodAuthentication::email_code_passwordless_verify()
methodAuthentication::sms_code_passwordless_verify()
methodAuthentication::code_exchange()
method now throws anApiException
if class-levelclient_secret
is empty (would be throwing an error from the HTTP request failure before)Authentication::client_credentials()
method now throws anApiException
ifaudience
is emptyOther changes
Authentication::get_authorize_link()
now adds class-level scopes and audience if none are passed inAuthentication::get_logout_link()
will now accepttrue
as theclient_id
parameter to use class-level valueAuthentication
classTesting
Checklist