Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated Authentication methods and add types #385

Merged
merged 1 commit into from
Oct 18, 2019

Conversation

joshcanhelp
Copy link
Contributor

Changes

Breaking Changes

  • Authentication class instantiation requires a client_id argument
  • Removed deprecated Authentication::setApiClient() method
  • Removed deprecated Authentication::authorize_with_ro() method
  • Removed deprecated Authentication::authorize_with_accesstoken() method
  • Removed deprecated Authentication::impersonate() method
  • Removed deprecated Authentication::email_code_passwordless_verify() method
  • Removed deprecated Authentication::sms_code_passwordless_verify() method
  • Authentication::code_exchange() method now throws an ApiException if class-level client_secret is empty (would be throwing an error from the HTTP request failure before)
  • Authentication::client_credentials() method now throws an ApiException if audience is empty

Other changes

  • Authentication::get_authorize_link() now adds class-level scopes and audience if none are passed in
  • Authentication::get_logout_link() will now accept true as the client_id parameter to use class-level value
  • Parameter and return types
  • Strict typing for Authentication class

Testing

  • This change modifies test coverage
  • This change has been tested on PHP 7.1

Checklist

  • All existing and new tests complete without errors.
  • The correct base branch is being used.

@joshcanhelp joshcanhelp requested a review from a team October 18, 2019 00:15
@joshcanhelp joshcanhelp added this to the 7.0.0 milestone Oct 18, 2019
@joshcanhelp joshcanhelp merged commit 969755d into 7.0.0-dev Oct 18, 2019
@joshcanhelp joshcanhelp deleted the cleanup-authentication-class branch October 18, 2019 18:07
@joshcanhelp joshcanhelp changed the title Remove deprecated; add types; require client_id Remove deprecated Authentication methods and add types Jan 14, 2020
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants