Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove session cookie expiration option #389

Merged
merged 2 commits into from
Oct 31, 2019

Conversation

joshcanhelp
Copy link
Contributor

@joshcanhelp joshcanhelp commented Oct 29, 2019

Changes

Remove the session cookie expiration option throughout the SDK. The session cookie expiration should be managed in the application, not in this SDK. If you were using this setting before, see the PHP core function session_set_cookie_params() to set this value after upgrading:

https://www.php.net/manual/en/function.session-set-cookie-params.php

Breaking changes:

  • Remove SessionStore::COOKIE_EXPIRES constant

Other changes:

  • Remove 2nd argument for SessionStore class
  • Remove session_cookie_expires config option for Auth0 class

Testing

  • This change modifies test coverage
  • This change has been tested on PHP 7.2

Checklist

  • All existing and new tests complete without errors.
  • The correct base branch is being used.

@joshcanhelp joshcanhelp added this to the 7.0.0 milestone Oct 31, 2019
@joshcanhelp joshcanhelp marked this pull request as ready for review October 31, 2019 03:41
@joshcanhelp joshcanhelp requested a review from a team October 31, 2019 03:41
@joshcanhelp joshcanhelp merged commit c49250d into 7.0.0-dev Oct 31, 2019
@joshcanhelp joshcanhelp deleted the remove-session-cookie-opt branch October 31, 2019 14:56
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants