Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change client secret requirements #390

Merged
merged 2 commits into from
Nov 1, 2019
Merged

Change client secret requirements #390

merged 2 commits into from
Nov 1, 2019

Conversation

joshcanhelp
Copy link
Contributor

@joshcanhelp joshcanhelp commented Oct 29, 2019 •
edited
Loading

Changes

  • Remove the requirement for a client secret to be passed to the Auth0 class
  • Decode the secret in the constructor so it's decoded throughout

Testing

  • This change modifies test coverage
  • This change has been tested on PHP 7.2

Checklist

  • All existing and new tests complete without errors.
  • The correct base branch is being used.

@joshcanhelp joshcanhelp changed the base branch from master to 7.0.0-dev October 29, 2019 22:54
@joshcanhelp joshcanhelp force-pushed the change-client-secret-requirements branch from bf84b22 to 9ac6d52 Compare October 31, 2019 03:25
@joshcanhelp joshcanhelp force-pushed the change-client-secret-requirements branch from 9ac6d52 to abc9219 Compare October 31, 2019 19:52
@joshcanhelp joshcanhelp marked this pull request as ready for review October 31, 2019 20:18
@joshcanhelp joshcanhelp requested a review from a team October 31, 2019 20:18
@joshcanhelp joshcanhelp merged commit d25b3d2 into 7.0.0-dev Nov 1, 2019
@joshcanhelp joshcanhelp deleted the change-client-secret-requirements branch November 1, 2019 15:23
@joshcanhelp joshcanhelp added this to the 7.0.0 milestone Jan 14, 2020
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stevehobbsdev stevehobbsdev stevehobbsdev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@joshcanhelp @stevehobbsdev