Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Auth0 class constructor for clarification and better defaults #394

Merged
merged 3 commits into from
Nov 11, 2019

Conversation

joshcanhelp
Copy link
Contributor

@joshcanhelp joshcanhelp commented Oct 31, 2019

Changes

Potentially breaking changes:

  • Add ENV fallbacks for required settings:
    • AUTH0_DOMAIN will be used if the domain configuration key is empty
    • AUTH0_CLIENT_ID will be used if the client_id configuration key is empty
    • AUTH0_REDIRECT_URI will be used if the redirect_uri configuration key is empty
  • Change skip_userinfo default to true. This means that applications no setting this value will get the user identity from the ID token rather than an extra HTTP call to the /userinfo endpoint.
  • Remove unused debugging mode and public Auth0->setDebugger() method
  • Base64 decode Client Secret in the constructor to be used as-is within the class

Testing

  • This change adds test coverage
  • This change has been tested on the latest version of PHP

Checklist

  • All existing and new tests complete without errors.
  • The correct base branch is being used.

@joshcanhelp joshcanhelp changed the title Cleanup auth0 constructor Cleanup Auth0 class constructor for clarification and better defaults Nov 11, 2019
@joshcanhelp joshcanhelp marked this pull request as ready for review November 11, 2019 17:08
@joshcanhelp joshcanhelp requested a review from a team November 11, 2019 17:08
@joshcanhelp joshcanhelp added this to the 7.0.0 milestone Nov 11, 2019
Copy link
Contributor

@damieng damieng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the removal of setDebugger a breaking change?

@joshcanhelp
Copy link
Contributor Author

@damieng - Potentially, yes. This is for a major release so we're ok. I added more specifics in the PR description.

@joshcanhelp joshcanhelp merged commit 939864f into 7.0.0-dev Nov 11, 2019
@joshcanhelp joshcanhelp deleted the cleanup-auth0-constructor branch November 11, 2019 19:28
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants