Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SameSite cookie attribute handling #400

Merged
merged 4 commits into from
Dec 2, 2019
Merged

Conversation

joshcanhelp
Copy link
Contributor

@joshcanhelp joshcanhelp commented Nov 19, 2019

Changes

This PR addresses upcoming changes to SameSite cookie attributes early next year. For a complete explanation of what SameSite is and what's changing, please see the web.dev article below.

This PR will:

  • Set default cookie SameSite attribute to Lax
  • Set cookie SameSite attribute for form_post response mode to None (with a legacy fallback)

References

Web.dev: SameSite cookies explained

Testing

  • This change adds test coverage
  • This change has been tested on PHP 7.1 and 7.2

Checklist

  • All existing and new tests complete without errors.
  • The correct base branch is being used.

@joshcanhelp joshcanhelp marked this pull request as ready for review November 20, 2019 17:48
@joshcanhelp joshcanhelp requested a review from a team November 20, 2019 17:48
@joshcanhelp joshcanhelp changed the title Add samesite handling Add SameSite cookie attribute handling Nov 20, 2019
src/Store/CookieStore.php Show resolved Hide resolved
src/Store/CookieStore.php Show resolved Hide resolved
src/Store/CookieStore.php Show resolved Hide resolved
@joshcanhelp joshcanhelp merged commit 8081f94 into 7.0.0-dev Dec 2, 2019
@lbalmaceda lbalmaceda deleted the add-samesite-handling branch December 3, 2019 15:05
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants