Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert caching to PSR-16 interface #403

Merged
merged 2 commits into from
Dec 3, 2019
Merged

Conversation

joshcanhelp
Copy link
Contributor

@joshcanhelp joshcanhelp commented Dec 3, 2019

Changes

This switches the existing caching interface for a PSR-16 one. The caching needs for this library are straightforward so we chose the simpler interface.

Potentially breaking changes:

  • Remove interface Auth0\SDK\Helpers\Cache\CacheHandler
  • Remove class Auth0\SDK\Helpers\Cache\FileSystemCacheHandler

References

Closes #282

Testing

  • This change adds test coverage
  • This change has developed in PHP 7.1

Checklist

  • All existing and new tests complete without errors.
  • The correct base branch is being used - 7.0.0-dev

@joshcanhelp joshcanhelp added this to the 7.0.0 milestone Dec 3, 2019
@joshcanhelp joshcanhelp marked this pull request as ready for review December 3, 2019 05:47
@joshcanhelp joshcanhelp requested a review from a team December 3, 2019 05:47
@joshcanhelp joshcanhelp merged commit dad0170 into 7.0.0-dev Dec 3, 2019
@lbalmaceda lbalmaceda deleted the add-psr-cache-interface branch December 3, 2019 17:50
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants