Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add types for StoreInterface and implementors; add back EmptyStore #414

Merged
merged 1 commit into from
Jan 15, 2020
Merged

Add types for StoreInterface and implementors; add back EmptyStore #414

merged 1 commit into from
Jan 15, 2020

Conversation

joshcanhelp
Copy link
Contributor

Changes

  • Add types to StoreInterface and implementors
  • Add back EmptyStore for use when there is no persistence

Testing

  • This change adds test coverage

Checklist

  • All existing and new tests complete without errors.
  • The correct base branch is being used.

@joshcanhelp joshcanhelp requested a review from a team January 15, 2020 15:50
@joshcanhelp joshcanhelp added this to the 7.0.0 milestone Jan 15, 2020
@joshcanhelp joshcanhelp mentioned this pull request Jan 15, 2020
Merged
@joshcanhelp joshcanhelp merged commit f94e941 into 7.0.0-dev Jan 15, 2020
@joshcanhelp joshcanhelp deleted the add-back-enpty-store-plus-types branch January 15, 2020 16:25
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lbalmaceda lbalmaceda lbalmaceda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@joshcanhelp @lbalmaceda