Add signing key rotation and custom JWKS URI support #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshcanhelp
force-pushed
the
add-signing-key-rotation
branch
from
6837b51
to
bf13bd8
Compare
joshcanhelp
force-pushed
the
add-signing-key-rotation
branch
from
bf13bd8
to
f557e67
Compare
lbalmaceda
suggested changes
Feb 7, 2020
joshcanhelp
force-pushed
the
add-signing-key-rotation
branch
from
dd2b886
to
6126574
Compare
joshcanhelp
commented
Feb 8, 2020
| $keys = $this->cache->get($cache_key); | ||
| if (is_array($keys) && ! empty($keys)) { | ||
| return $keys; | ||
| $jwks_url = $jwks_url ?? $this->guzzleOptions['base_uri'] ?? ''; |
There was a problem hiding this comment.
It turns out there is a base_uri setting in the HTTP library already so I'm leveraging that here. We need to know the final URI we're using here to check the cache (if necessary). I'm sticking with the "return empty array if URL is empty" because that is indicating "we don't have keys for that URL" and will fail with the "no kid found in that JWKS" error mentioned earlier. Same outcome for a malformed/empty JWKS.
|
@lbalmaceda - Ready for you again! |
lbalmaceda
approved these changes
Feb 10, 2020
|
Had to force merge, CodeCov was not completing. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
References
Closes #417, #426
PSR-16 cache interface
Testing
Checklist
master