Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw InvalidTokenException instead of RuntimeException when parsing malformed token (fix #438) #439

Merged
merged 1 commit into from
Aug 6, 2020

Conversation

B-Galati
Copy link
Contributor

@B-Galati B-Galati commented Jun 17, 2020

Hello !

Description

Fix #438

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@B-Galati B-Galati requested a review from a team June 17, 2020 13:49
@B-Galati
Copy link
Contributor Author

@joshcanhelp Hello! Is the CI broken?

Copy link
Contributor

@lbalmaceda lbalmaceda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lbalmaceda lbalmaceda closed this Jun 22, 2020
@lbalmaceda
Copy link
Contributor

The configuration looks good. Let me try to kick the build.

@lbalmaceda lbalmaceda reopened this Jun 22, 2020
@lbalmaceda
Copy link
Contributor

Looks like these integration tests need valid credentials to be set up in order for them to run. Sadly, I won't be able to provide them. Let me reach out to the team.

@B-Galati
Copy link
Contributor Author

Thanks @lbalmaceda 🙏

@B-Galati
Copy link
Contributor Author

@lbalmaceda @joshcanhelp friendly ping 🙏

@lbalmaceda
Copy link
Contributor

@B-Galati apologies for missing the follow-up. We're tracking the refactor of those tests that require client_secret internally as SDK-1751 and will be picking it up the next week. After that's fixed, we can rebase this PR and checks should pass.

@jimmyjames
Copy link
Contributor

I've verified these changes locally, so going to bypass checks to not block this PR any longer. We will be doing some refactoring to better enable tests running on PRs. Thanks for your patience!

@jimmyjames jimmyjames merged commit b0a7be1 into auth0:master Aug 6, 2020
@jimmyjames jimmyjames modified the milestones: 7.2.1, 7.3.0 Aug 27, 2020
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TokenVerifier::verify throws a \RuntimeException instead of an InvalidTokenException
4 participants