-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Throw InvalidTokenException instead of RuntimeException when parsing malformed token (fix #438) #439
Conversation
…malformed token (fix auth0#438)
@joshcanhelp Hello! Is the CI broken? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The configuration looks good. Let me try to kick the build. |
Looks like these integration tests need valid credentials to be set up in order for them to run. Sadly, I won't be able to provide them. Let me reach out to the team. |
Thanks @lbalmaceda 🙏 |
@lbalmaceda @joshcanhelp friendly ping 🙏 |
@B-Galati apologies for missing the follow-up. We're tracking the refactor of those tests that require client_secret internally as |
I've verified these changes locally, so going to bypass checks to not block this PR any longer. We will be doing some refactoring to better enable tests running on PRs. Thanks for your patience! |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Hello !
Description
Fix #438
Testing
Checklist
master