Ensure ?include_totals are handled on GET /users and GET /roles requests for Management API #476
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.
Description
This PR addresses a bug reported in #475 in which we aren't handling the ?include_totals query param with GET /users and GET /roles Management API endpoints in certain circumstances. This PR also updates our tests to accommodate this param's presence.
References
Testing
This PR updates the Roles and Users tests to reflect the presence of the ?include_totals query param. The changes can be tested locally with
composer test
, or observed by the CircleCI test result on this PR.Checklist
master