Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure ?include_totals are handled on GET /users and GET /roles requests for Management API #476

Merged
merged 4 commits into from
Jan 26, 2021

Conversation

evansims
Copy link
Member

@evansims evansims commented Jan 25, 2021

By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

This PR addresses a bug reported in #475 in which we aren't handling the ?include_totals query param with GET /users and GET /roles Management API endpoints in certain circumstances. This PR also updates our tests to accommodate this param's presence.

References

Testing

This PR updates the Roles and Users tests to reflect the presence of the ?include_totals query param. The changes can be tested locally with composer test, or observed by the CircleCI test result on this PR.

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@evansims evansims requested a review from a team as a code owner January 25, 2021 17:41
@evansims evansims marked this pull request as draft January 25, 2021 17:42
@evansims evansims marked this pull request as ready for review January 25, 2021 17:45
@evansims evansims merged commit 2edaac2 into master Jan 26, 2021
@evansims evansims deleted the fix-user-getall-pagination branch January 26, 2021 14:52
@evansims evansims added this to the 7.6.2 milestone Feb 1, 2021
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Users getAll has mistake of pagination
2 participants