Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK-2552] Change method visibility of getState to public #498

Merged
merged 3 commits into from
May 3, 2021

Conversation

evansims
Copy link
Member

@evansims evansims commented May 3, 2021

Description

This PR changes the visibility of the Auth0\SDK\Auth0::getState method from protected to public. This change was requested by the community. This could be useful for client applications in troubleshooting invalid state CoreExceptions.

Closes #495

References

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@evansims evansims requested a review from a team as a code owner May 3, 2021 18:08
@evansims evansims added this to the 7.9.0 milestone May 3, 2021
@evansims evansims closed this May 3, 2021
@evansims evansims reopened this May 3, 2021
@evansims
Copy link
Member Author

evansims commented May 3, 2021

Sorry for slipping the Snyk change in with this, it's unrelated but breaking PR approval, so 🤷‍♂️

@evansims evansims merged commit e3dcae4 into auth0:master May 3, 2021
@evansims evansims deleted the feat-sdk-2552 branch May 3, 2021 19:35
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[7.9] Make Auth0\SDK\Auth0::getState a public method
2 participants