[SDK-2662] Add missing API2 POST /tickets/password-change params. #523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbalmaceda
suggested changes
Jul 16, 2021
There was a problem hiding this comment.
I'd expect new tests here. It seems some functions from this file were not covered in the past. I'd suggest writing those tests before the change to clear out potential breaking changes.
@lbalmaceda Good call 👍 I've expanded the test coverage for those methods, along with the new parameters. Let me know what you think |
lbalmaceda
approved these changes
Jul 20, 2021
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two missing parameters related to API2's POST /tickets/password-change endpoint to the relevant methods within
Auth0\API\Management\Tickets. Closes #522