Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Importing users #61

Merged
merged 1 commit into from
Feb 3, 2016
Merged

Conversation

polishdeveloper
Copy link

  • fixed RequetBulder, now properly sends multipart data
  • fixed APIJobs method names

 - fixed RequetBulder, now properly sends multipart data
 - fixed Jobs method names
@polishdeveloper
Copy link
Author

Additionally there is something wrong with your tests -> all fail because of incorrect URL: "https:///api/v2/connections" -> looks like there is /api somewhere hardcoded

@polishdeveloper
Copy link
Author

Ok, I found it - tests fail because .env is not specified and, URL used in tests is "http://" . env['DOMAIN'] . "/api/v2" but because env['DOMAIN'] is empty it creates "http:///api/v2" and Guzzle throws error it's not valid URL @glena can you fix that ?

@glena
Copy link
Contributor

glena commented Feb 3, 2016

First thx for the PR, I feel stupid after see that :)

Second about the CI, yes the thing is that it is using some env vars in travis, I have to check if there is a better way to store them (maybe encripted in the .travis file).

glena added a commit that referenced this pull request Feb 3, 2016
@glena glena merged commit f98b0be into auth0:master Feb 3, 2016
@github-actions
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants