Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Update test coverage for tenant domain validation changes #756

Merged
merged 3 commits into from
Jan 11, 2024

Conversation

ramonschriks
Copy link
Contributor

Changes

Added test coverage for previous added issuer claim validation with custom domain.

  • Added expecting failure scenario with invalid domain not matching token issuer
  • Added expecting failure scenario with invalid domain AND invalid custom domain not matching token issuer
  • Added scenario with custom domain matching token issuer, should validate.
  • Added scenario with custom domain not matching token issuer, should validate with tenant domain

References

Ref: #755

Contributor Checklist

ramonschriks and others added 3 commits January 9, 2024 17:40
Fix in not falling through exception after fallback validator succeeded...

Signed-off-by: ramonschriks <ramon.nmgn@live.nl>
…lback to tenant domain in case of custom domain)
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2dd8a74) 99.97% compared to head (f32478b) 100.00%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@              Coverage Diff              @@
##               main      #756      +/-   ##
=============================================
+ Coverage     99.97%   100.00%   +0.02%     
  Complexity     1383      1383              
=============================================
  Files            62        62              
  Lines          4781      4781              
=============================================
+ Hits           4780      4781       +1     
+ Misses            1         0       -1     
Flag Coverage Δ
unittestsvalidate 100.00% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@evansims evansims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; thanks @ramonschriks!

@evansims evansims merged commit a6adf46 into auth0:main Jan 11, 2024
23 checks passed
@evansims evansims changed the title Added test coverage test: Update test coverage for tenant domain validation changes Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants