Provide an Ivy Distribution #281
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederikprijck
commented
Feb 8, 2022
| @@ -9,7 +9,7 @@ | |||
| "start:local:playground": "ng serve --configuration=local", | |||
| "prebuild": "npm run update-useragent", | |||
| "build": "ng build && npm run build:schematics", | |||
| "build:prod": "ng build --prod && npm run build:schematics", | |||
| "build:prod": "ng build --configuration production && npm run build:schematics", | |||
There was a problem hiding this comment.
Renamed this command as it was giving a warning. Not related to Ivy.
frederikprijck
commented
Feb 8, 2022
| @@ -4,5 +4,5 @@ | |||
| "lib": { | |||
| "entryFile": "src/public-api.ts" | |||
| }, | |||
| "whitelistedNonPeerDependencies": ["tslib", "@auth0/auth0-spa-js"] | |||
| "allowedNonPeerDependencies": ["tslib", "@auth0/auth0-spa-js"] | |||
There was a problem hiding this comment.
Renamed this property as it was giving a warning. Not related to Ivy.
frederikprijck
commented
Feb 8, 2022
| "@angular/router": ">=9 <=13" | ||
| "@angular/common": ">=11 <=13", | ||
| "@angular/core": ">=11 <=13", | ||
| "@angular/router": ">=11 <=13" |
There was a problem hiding this comment.
Dropping support for Angular 9 and 10, as they aren't supported anymore.
frederikprijck
commented
Feb 8, 2022
| @@ -2,6 +2,6 @@ | |||
| { | |||
| "extends": "./tsconfig.lib.json", | |||
| "angularCompilerOptions": { | |||
| "enableIvy": false | |||
| "compilationMode": "partial" | |||
There was a problem hiding this comment.
Use Ivy for compilation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Compiles the Library without disabling Ivy. Installing our SDK in Angular13 generates a warning because of the fact that we do not compile using Ivy. This was done previously to support Angular 8 up until 10. However, Angular itself does not support any version prior to 11, so this PR also bumps our minimal peer dependency version to 11, ensuring we can compile using Ivy.
Theoretically this is a breaking change, as it breaks support for Angular 9 and 10. However as those versions of Angular aren't supported by Angular itself, it's worth considering releasing this as a minor.
References
Closes #255
Checklist
master