Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Angular to 14 #324

Closed
wants to merge 16 commits into from
Closed

Update Angular to 14 #324

wants to merge 16 commits into from

Conversation

frederikprijck
Copy link
Member

@frederikprijck frederikprijck commented Jul 6, 2022

Description

Updates Angular to 14. Also updates typedoc because of a conflicting peerDependency on typescript.
This also migrates to ESLint, as TSLint has been removed in the process of upgrading to 14.

References

Closes #255

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@frederikprijck frederikprijck marked this pull request as ready for review August 9, 2022 09:43
@frederikprijck frederikprijck requested a review from a team as a code owner August 9, 2022 09:43
@mcarey1590
Copy link

Is there an ETA on when this version will be released?

@frederikprijck
Copy link
Member Author

frederikprijck commented Sep 27, 2022

I had a conversation with the Angular team and concluded the following:

When you compile an SDK with Angular 14 and compilationMode set to partial, the SDK will only work with Angular 14+.
However, as we still need to support Angular 12 and 13, it appears to be that we have two options:

  • Create a separate version for every major version of Angular
  • Compile using the lowest supported Angular version, currently being 12.

Given we have no specific features from angular apart from a service and an interceptor, I believe we should be fine to stick with Angular 12, that would have full support for Angular 12, 13, 14 and 15.

However, that would mean we can not merge this PR yet, but can only do so once Angular has dropped support for Angular 12 and 13. Maintaining multiple versions comes with a cost that is not worth it for our SDK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide an Ivy distribution
3 participants