Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not disable Ivy but use compilationMode partial #345

Merged
merged 3 commits into from
Sep 30, 2022

Conversation

frederikprijck
Copy link
Member

Description

Do not disable Ivy when compiling the library, also ensure we compile with compilationMode set to partial.
Doing so, would allow our library to be used with any version of Angular that is the same or higher as the version of Angular used to compile this library (which is Angular 12 at the time of opening this PR).

This drops support for any version of Angular that is below the version used to compile the SDK. Meaning, that once this change is released, we will have no longer support for Angular

Closes #255

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not the default branch

@frederikprijck frederikprijck requested a review from a team as a code owner September 29, 2022 05:43
@frederikprijck frederikprijck changed the title Do not disableIvy but use compilationMode partial Do not disable Ivy but use compilationMode partial Sep 29, 2022
@Lonli-Lokli
Copy link

@frederikprijck thanks for your fix, looks good to me.
Just one question, is it necessary to limit upper Angular version, ie <=14 ?

@frederikprijck
Copy link
Member Author

frederikprijck commented Sep 29, 2022

That may not be needed, but sounds out of scope for what's being addressed here.

We do that because we want to signal we have not tested it on 15, we ofcourse will test it on 15 once it's stable and update accordingly to properly signal support.

@frederikprijck frederikprijck enabled auto-merge (squash) September 29, 2022 07:05
@frederikprijck frederikprijck merged commit 8918d53 into master Sep 30, 2022
@frederikprijck frederikprijck deleted the feat/use-ivy-partial branch September 30, 2022 09:19
@frederikprijck frederikprijck mentioned this pull request Oct 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide an Ivy distribution
3 participants