Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error handling for trigger bindings #991

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

kushalshit27
Copy link
Contributor

@kushalshit27 kushalshit27 commented Nov 27, 2024

🔧 Changes

Add error handling for trigger bindings for:

export fails on triggers with error: "cannot list action bindings for an entity-bound trigger"

📚 References

#988
#990

🔬 Testing

  • unit and e2e test pass

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@kushalshit27 kushalshit27 marked this pull request as ready for review November 27, 2024 17:40
@kushalshit27 kushalshit27 requested a review from a team as a code owner November 27, 2024 17:40
@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 80.24%. Comparing base (a13e794) to head (950690d).

Files with missing lines Patch % Lines
src/tools/auth0/handlers/triggers.ts 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #991      +/-   ##
==========================================
- Coverage   80.30%   80.24%   -0.06%     
==========================================
  Files         125      125              
  Lines        4432     4435       +3     
  Branches      862      863       +1     
==========================================
  Hits         3559     3559              
- Misses        516      519       +3     
  Partials      357      357              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kushalshit27 kushalshit27 merged commit 88230e9 into master Nov 28, 2024
8 checks passed
@kushalshit27 kushalshit27 deleted the DXCDT-746-fix-entity-bound-trigger-error branch November 28, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants