-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK-3508] Fix Integration Test CI for Android #282
Conversation
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #282 +/- ##
=========================================
Coverage 96.08% 96.08%
Complexity 86 86
=========================================
Files 97 97
Lines 1611 1611
Branches 331 331
=========================================
Hits 1548 1548
Misses 49 49
Partials 14 14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Co-authored-by: Rita Zerrizuela <zeta@widcket.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for fixing this!
Just a couple things:
- Let's stick, if possible, to the Circle CI Flutter Orb unless absolutely necessary.
- Let's try to avoid hardcoded absolute paths whenever possible.
Hey @Widcket, Great review. I have updated both the concerns and they should GTG now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
📋 Changes
We have fixed the CI for Android Integration test in this PR.
hints
that has been provided Appium Inspector as resource-id is not present in classic UL where as new UL has them.📎 References
http://appium.io/docs/en/2.0/
https://discuss.circleci.com/t/failed-to-run-python-script-directly-pyenv-version-name-command-not-found/37526/2
https://github.com/CircleCI-Public/flutter-orb/blob/main/src/scripts/install-sdk.sh#L21
🎯 Testing
This PR adds integration tests