Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK-3508] Fix Integration Test CI for Android #282

Merged
merged 14 commits into from
Jul 11, 2023
Merged

Conversation

poovamraj
Copy link
Contributor

@poovamraj poovamraj commented Jul 3, 2023

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

📋 Changes

We have fixed the CI for Android Integration test in this PR.

  • We have used appium to run these tests as it is more reliable.
  • The matcher to find login in Android Integration Test is using hints that has been provided Appium Inspector as resource-id is not present in classic UL where as new UL has them.
  • We also screen record the integration test in Android
  • We use xlarge resource class as large and below causes emulator to fail at times.

📎 References

http://appium.io/docs/en/2.0/
https://discuss.circleci.com/t/failed-to-run-python-script-directly-pyenv-version-name-command-not-found/37526/2
https://github.com/CircleCI-Public/flutter-orb/blob/main/src/scripts/install-sdk.sh#L21

🎯 Testing

This PR adds integration tests

@poovamraj poovamraj requested a review from a team as a code owner July 3, 2023 19:57
@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (6e25f10) 96.08% compared to head (c710b3b) 96.08%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #282   +/-   ##
=========================================
  Coverage     96.08%   96.08%           
  Complexity       86       86           
=========================================
  Files            97       97           
  Lines          1611     1611           
  Branches        331      331           
=========================================
  Hits           1548     1548           
  Misses           49       49           
  Partials         14       14           
Flag Coverage Δ
auth0_flutter 100.00% <ø> (ø)
auth0_flutter_android 96.55% <ø> (ø)
auth0_flutter_ios 99.84% <ø> (ø)
auth0_flutter_platform_interface 87.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
.circleci/config.yml Outdated Show resolved Hide resolved
appium-test/package.json Outdated Show resolved Hide resolved
Co-authored-by: Rita Zerrizuela <zeta@widcket.com>
appium-test/test.js Outdated Show resolved Hide resolved
Copy link
Contributor

@Widcket Widcket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for fixing this!

Just a couple things:

  • Let's stick, if possible, to the Circle CI Flutter Orb unless absolutely necessary.
  • Let's try to avoid hardcoded absolute paths whenever possible.

@poovamraj
Copy link
Contributor Author

Hey @Widcket, Great review. I have updated both the concerns and they should GTG now.

@poovamraj poovamraj requested a review from Widcket July 11, 2023 21:17
.circleci/config.yml Outdated Show resolved Hide resolved
@poovamraj poovamraj requested a review from Widcket July 11, 2023 21:24
Copy link
Contributor

@Widcket Widcket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Widcket Widcket merged commit f165559 into main Jul 11, 2023
@Widcket Widcket deleted the sdk-3508/smoke-tests branch July 11, 2023 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants