Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

af: Use Application Context for Credentials Manager #289

Merged
merged 4 commits into from
Jul 11, 2023

Conversation

poovamraj
Copy link
Contributor

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality - N/A - Changes are internal

📋 Changes

We are using applicationContext to fetch the credentials instead of Activity which is not required and could cause issues when credentials are fetched from outside an activity

📎 References

#233

🎯 Testing

We have updated the existing Unit Tests and added check that proper context is set.

@poovamraj poovamraj requested a review from a team as a code owner July 11, 2023 14:26
@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Patch coverage: 80.00% and project coverage change: -0.06 ⚠️

Comparison is base (d72bf76) 96.14% compared to head (59cbf46) 96.08%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #289      +/-   ##
============================================
- Coverage     96.14%   96.08%   -0.06%     
- Complexity       85       86       +1     
============================================
  Files            97       97              
  Lines          1609     1611       +2     
  Branches        331      331              
============================================
+ Hits           1547     1548       +1     
  Misses           49       49              
- Partials         13       14       +1     
Flag Coverage Δ
auth0_flutter 100.00% <ø> (ø)
auth0_flutter_android 96.55% <80.00%> (-0.19%) ⬇️
auth0_flutter_ios 99.84% <ø> (ø)
auth0_flutter_platform_interface 87.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...th0_flutter/CredentialsManagerMethodCallHandler.kt 90.00% <75.00%> (-4.74%) ⬇️
...tlin/com/auth0/auth0_flutter/Auth0FlutterPlugin.kt 72.97% <100.00%> (+0.75%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@poovamraj poovamraj mentioned this pull request Jul 11, 2023
6 tasks
@Widcket Widcket changed the title Use Application Context for Credentials Manager af: Use Application Context for Credentials Manager Jul 11, 2023
@Widcket Widcket merged commit 6e25f10 into main Jul 11, 2023
@Widcket Widcket deleted the fix-cred-man-using-activity branch July 11, 2023 20:40
@Widcket Widcket mentioned this pull request Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants