Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PKCE-related documentation #300

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Aug 11, 2023

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

📋 Changes

Recently there have been some changes in Manage, and now the Token Endpoint Authentication Method setting no longer shows up for mobile apps (because for this kind of app it must be None). Whereas for regular web apps and SPAs it's been moved to another tab:

Screenshot 2023-08-11 at 1 55 22 PM

Since it was possible (before this change) to set it to an invalid value for mobile apps, we had to point this out in the README of the app-facing package. Now that this setting is no longer available for mobile apps and was moved for SPAs, this PR reworks the respective documentation.

@Widcket Widcket added documentation Improvements or additions to documentation review:tiny Tiny review labels Aug 11, 2023
@Widcket Widcket requested a review from a team as a code owner August 11, 2023 13:48
@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Patch coverage has no change and project coverage change: +2.51% 🎉

Comparison is base (d809aa0) 93.57% compared to head (a294d9a) 96.08%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #300      +/-   ##
============================================
+ Coverage     93.57%   96.08%   +2.51%     
  Complexity       86       86              
============================================
  Files            70       97      +27     
  Lines           965     1611     +646     
  Branches         50      331     +281     
============================================
+ Hits            903     1548     +645     
  Misses           49       49              
- Partials         13       14       +1     
Flag Coverage Δ
auth0_flutter 100.00% <ø> (ø)
auth0_flutter_android 96.55% <ø> (ø)
auth0_flutter_ios 99.84% <ø> (?)
auth0_flutter_platform_interface 87.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 27 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Widcket Widcket merged commit f765bf2 into main Aug 11, 2023
7 checks passed
@Widcket Widcket deleted the chore/update-PKCE-messaging branch August 11, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
check title documentation Improvements or additions to documentation review:tiny Tiny review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants