-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase the timout of iOS smoke tests #359
Merged
Widcket
merged 2 commits into
feature/macos-support
from
macos-support/smoke-tests-timeout
Nov 30, 2023
Merged
Increase the timout of iOS smoke tests #359
Widcket
merged 2 commits into
feature/macos-support
from
macos-support/smoke-tests-timeout
Nov 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/macos-support #359 +/- ##
========================================================
Coverage ? 96.36%
========================================================
Files ? 98
Lines ? 1596
Branches ? 328
========================================================
Hits ? 1538
Misses ? 50
Partials ? 8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Widcket
force-pushed
the
macos-support/smoke-tests-timeout
branch
from
November 25, 2023 00:42
f9e76b8
to
5c310ec
Compare
stevehobbsdev
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📋 Changes
Currently, the iOS smoke tests have a timeout of 10 seconds when waiting for UI elements to appear. Looking at recent failures, this value does not seem to be enough, as the UL page hasn't finished rendering by the time this timeout expires:
This PR raises the timeout to 30m seconds to give the UL page enough time to finish rendering.