Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the timout of iOS smoke tests #359

Merged
merged 2 commits into from
Nov 30, 2023

Conversation

Widcket
Copy link
Contributor

@Widcket Widcket commented Nov 25, 2023

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

📋 Changes

Currently, the iOS smoke tests have a timeout of 10 seconds when waiting for UI elements to appear. Looking at recent failures, this value does not seem to be enough, as the UL page hasn't finished rendering by the time this timeout expires:

Screenshot 2023-11-25 at 00 01 53

This PR raises the timeout to 30m seconds to give the UL page enough time to finish rendering.

Copy link

codecov bot commented Nov 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (feature/macos-support@19afea6). Click here to learn what that means.

Additional details and impacted files
@@                   Coverage Diff                    @@
##             feature/macos-support     #359   +/-   ##
========================================================
  Coverage                         ?   96.36%           
========================================================
  Files                            ?       98           
  Lines                            ?     1596           
  Branches                         ?      328           
========================================================
  Hits                             ?     1538           
  Misses                           ?       50           
  Partials                         ?        8           
Flag Coverage Δ
auth0_flutter 100.00% <0.00%> (?)
auth0_flutter_android 97.35% <0.00%> (?)
auth0_flutter_ios 99.85% <0.00%> (?)
auth0_flutter_platform_interface 87.03% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Widcket Widcket merged commit 8ae5155 into feature/macos-support Nov 30, 2023
17 checks passed
@Widcket Widcket deleted the macos-support/smoke-tests-timeout branch November 30, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants