Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Windows using WinUIEx #283

Merged
merged 2 commits into from
Oct 11, 2023
Merged

Add support for Windows using WinUIEx #283

merged 2 commits into from
Oct 11, 2023

Conversation

frederikprijck
Copy link
Member

@frederikprijck frederikprijck commented Oct 10, 2023

Changes

With MAUI not having built-in support for opening a browser on windows yet, we want to integrate support for Windows using WinUIEx, a community package to solve the lack of support for Windows.

See:

Relevant links for WinUIEx:

Checklist

@frederikprijck frederikprijck marked this pull request as ready for review October 10, 2023 15:02
@frederikprijck frederikprijck requested a review from a team as a code owner October 10, 2023 15:02
@dotMorten
Copy link

dotMorten commented Oct 10, 2023

Make sure you add the WebAuthenticator.CheckOAuthRedirectionActivation() to app startup in \Platforms\Windows\App.xaml.cs, as well as update the appxmanifest with your redirection scheme

@frederikprijck
Copy link
Member Author

frederikprijck commented Oct 10, 2023

Thanks for calling that out @dotMorten , I plan to add that to the documentation (and have done so in our sample app that we will publish).

There is also the change we want to document about the WindowsAppSDK as per https://dotmorten.github.io/WinUIEx/concepts/Maui.html, but I was unable to get 1.4.230822000 to work, so had to stick to WebUIEx 2.2.0.

Thanks for providing WebUIEx, I will ensure to call out we use WebUIEx for windows support to properly credit 👍 .

@frederikprijck frederikprijck merged commit 2bd7924 into beta Oct 11, 2023
3 checks passed
@frederikprijck frederikprijck deleted the feat/sdk-4627 branch October 11, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants