Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SDK-1642] Add missing methods from SPA JS #11

Merged
merged 2 commits into from
May 19, 2020
Merged

[SDK-1642] Add missing methods from SPA JS #11

merged 2 commits into from
May 19, 2020

Conversation

adamjmcgrath
Copy link
Contributor

@adamjmcgrath adamjmcgrath commented May 17, 2020 •
edited
Loading

Description

Add getTokenWithPopup, loginWithPopup and getIdTokenClaims

References

https://auth0.github.io/auth0-spa-js/classes/auth0client.html#gettokenwithpopup
https://auth0.github.io/auth0-spa-js/classes/auth0client.html#getidtokenclaims
https://auth0.github.io/auth0-spa-js/classes/auth0client.html#loginwithpopup

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing

Will switch base to master when error-handling-docs is merged

  • The correct base branch is being used, if not master

@adamjmcgrath adamjmcgrath changed the title Add missing methods from SPA JS [SDK-1642] Add missing methods from SPA JS May 17, 2020
@adamjmcgrath adamjmcgrath requested a review from a team May 17, 2020 11:30
@adamjmcgrath adamjmcgrath added CH: Added PR is adding feature or functionality medium This PR may require moderate effort to action, or contains many changes to review labels May 17, 2020
@adamjmcgrath adamjmcgrath changed the base branch from error-handling-docs to master May 19, 2020 07:57
@adamjmcgrath
The feedback I got was that redirectTo is too similar to redirect_uri…
bf71794 
… and should be changed to returnTo to avoid confusion
@adamjmcgrath adamjmcgrath merged commit 5d21aad into master May 19, 2020
@stevehobbsdev stevehobbsdev deleted the additional-methods branch May 19, 2020 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevehobbsdev stevehobbsdev stevehobbsdev approved these changes

Assignees
No one assigned
Labels
CH: Added PR is adding feature or functionality medium This PR may require moderate effort to action, or contains many changes to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamjmcgrath @stevehobbsdev