Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getToken methods were being called in the wrong scope #24

Merged
merged 1 commit into from
Jun 1, 2020
Merged

getToken methods were being called in the wrong scope #24

merged 1 commit into from
Jun 1, 2020

Conversation

adamjmcgrath
Copy link
Contributor

@adamjmcgrath adamjmcgrath commented May 31, 2020 •
edited
Loading

Description

Wrapping the token methods caused them to be called in the global scope when they should have been called in the scope of the Auth0Client instance

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@adamjmcgrath adamjmcgrath added the tiny This PR may require very low effort to action, or contains few changes to review label May 31, 2020
@adamjmcgrath adamjmcgrath requested a review from a team May 31, 2020 08:01
@adamjmcgrath adamjmcgrath added the CH: Fixed PR is fixing a bug label May 31, 2020
@adamjmcgrath adamjmcgrath merged commit 09edb84 into master Jun 1, 2020
@stevehobbsdev stevehobbsdev deleted the fix-get-token-scopes branch June 1, 2020 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevehobbsdev stevehobbsdev stevehobbsdev approved these changes

Assignees
No one assigned
Labels
CH: Fixed PR is fixing a bug tiny This PR may require very low effort to action, or contains few changes to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamjmcgrath @stevehobbsdev