Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK-1577] [SDK-1578] Add login functionality #5
[SDK-1577] [SDK-1578] Add login functionality #5
Changes from 6 commits
d65dc42
245b5dd
9058686
cb95e33
6781a40
d96b85b
94b296d
f475d21
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to use manual mocks to mock the Auth0Client class https://jestjs.io/docs/en/es6-class-mocks#manual-mock
This is so that I can export the methods as individual mocked methods, so I can do:
Rather than use automatic mocks and do this everywhere:
Since TS doesn't understand mocking in Jest, we do have to
ts-ignore
the additional importsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not something to change in this PR, but I think we need to think about why we're mocking the SPA SDK and whether that's the right thing, instead of mocking the resulting HTTP calls (or handling them with some kind of test proxy).
For the same reason we don't test or mock private methods, the fact we're using the SDK internally should just be that - an internal detail. HTTP calls out to the auth service are where the 'seams' are and it's the seams that should ideally be mocked. If we go down the path of mocking dependencies like these, we can lose sight of what happens when those dependencies change if we're always mocking out the ideal scenario.
This file was deleted.
This file was deleted.