Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/react19 #824

Merged
merged 7 commits into from
Jan 21, 2025
Merged

Feature/react19 #824

merged 7 commits into from
Jan 21, 2025

Conversation

tusharpandey13
Copy link
Contributor

@tusharpandey13 tusharpandey13 commented Jan 20, 2025

This change enables React 19 support for auth0-react
This change builds upon PR #819 by @leefreemanxyz

Changes

  • Version bumps of related packages in package.json, package-lock.json update.
  • Updated tests to use the new version of packages.
  • Added handling for an edge case where error was not thrown if popup was closed in loginWithPopup.
  • Updated sample code to use React 19.
  • Linting changes.

Commits

  • feat(react 19): update react to 19, testing libraries deps to latest and fix broken tests
  • chore: update @types/react and @types/react-dom to version 19.0.0
  • refactor: remove explicit return types for functional components in tests and providers
  • add explicit type annotations for React.JSX.Element
  • handle popup closed error not thrown
  • update example code
  • update tests
  • package json changes

Testing

PASSING

=============================== Coverage summary ===============================
Statements   : 100% ( 166/166 )
Branches     : 100% ( 72/72 )
Functions    : 100% ( 41/41 )
Lines        : 100% ( 158/158 )
================================================================================

Test Suites: 8 passed, 8 total
Tests:       81 passed, 81 total
Snapshots:   0 total
Time:        4.995 s
Ran all test suites.
  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not the default branch

@tusharpandey13 tusharpandey13 requested a review from a team as a code owner January 20, 2025 08:27
@louis-sanna-eki
Copy link

louis-sanna-eki commented Jan 20, 2025

@tusharpandey13 thx for your work, this will be useful for us! 👏

@tusharpandey13 tusharpandey13 merged commit 3aff9a8 into main Jan 21, 2025
18 of 20 checks passed
@tusharpandey13 tusharpandey13 deleted the feature/react19 branch January 21, 2025 04:51
@tusharpandey13 tusharpandey13 mentioned this pull request Jan 21, 2025
tusharpandey13 added a commit that referenced this pull request Jan 21, 2025
**Added**
- Feature/react19 [\#824](#824)
([tusharpandey13](https://github.com/tusharpandey13))
- Add ReversingLabs Workflow (Don't Merge)
[\#782](#782)
([developerkunal](https://github.com/developerkunal))

**Changed**
- Bump next from 13.5.6 to 14.1.1 in /examples/nextjs-app
[\#761](#761)
([dependabot[bot]](https://github.com/apps/dependabot))
- Bump @testing-library/react from 14.1.2 to 14.3.1
[\#757](#757)
([dependabot[bot]](https://github.com/apps/dependabot))
- Bump ts-jest from 29.1.1 to 29.1.5
[\#766](#766)
([dependabot[bot]](https://github.com/apps/dependabot))
- Bump cypress from 13.6.1 to 13.12.0
[\#770](#770)
([dependabot[bot]](https://github.com/apps/dependabot))
- Bump braces from 3.0.2 to 3.0.3
[\#773](#773)
([dependabot[bot]](https://github.com/apps/dependabot))
- Bump @types/jest from 29.5.11 to 29.5.12
[\#750](#750)
([dependabot[bot]](https://github.com/apps/dependabot))
- Bump @types/react from 18.2.45 to 18.2.64
[\#747](#747)
([dependabot[bot]](https://github.com/apps/dependabot))
- Bump browserstack-cypress-cli from 1.28.0 to 1.28.1
[\#715](#715)
([dependabot[bot]](https://github.com/apps/dependabot))
- Bump typedoc from 0.25.4 to 0.25.7
[\#713](#713)
([dependabot[bot]](https://github.com/apps/dependabot))

**Fixed**
- ci: changed pull_request_target to pull_request and removed the
authorize step [\#796](#796)
([desusai7](https://github.com/desusai7))
- Update codeowner file with new GitHub team name
[\#790](#790)
([stevenwong-okta](https://github.com/stevenwong-okta))
- Bump jose from 4.11.0 to 4.15.5 in /examples/users-api
[\#749](#749)
([dependabot[bot]](https://github.com/apps/dependabot))
- Workaround for failing "integration test (CRA)"
[\#769](#769)
([nandan-bhat](https://github.com/nandan-bhat))

**Security**
- Bump pretty-quick from 3.1.3 to 3.3.1
[\#736](#736)
([dependabot[bot]](https://github.com/apps/dependabot))
- Bump express from 4.18.2 to 4.19.2 in /examples/users-api
[\#754](#754)
([dependabot[bot]](https://github.com/apps/dependabot))
- Bump follow-redirects from 1.15.3 to 1.15.6
[\#752](#752)
([dependabot[bot]](https://github.com/apps/dependabot))
- Bump ws from 7.5.9 to 7.5.10
[\#768](#768)
([dependabot[bot]](https://github.com/apps/dependabot))
- Bump oidc-provider from 8.4.3 to 8.4.5
[\#720](#720)
([dependabot[bot]](https://github.com/apps/dependabot))
@tusharpandey13 tusharpandey13 mentioned this pull request Jan 21, 2025
tusharpandey13 added a commit that referenced this pull request Jan 21, 2025
**Added**
- Release v2.3.0 [\#825](#825)
([tusharpandey13](https://github.com/tusharpandey13))
- Feature/react19 [\#824](#824)
([tusharpandey13](https://github.com/tusharpandey13))
- Add ReversingLabs Workflow (Don't Merge)
[\#782](#782)
([developerkunal](https://github.com/developerkunal))

**Changed**
- ci: changed pull_request_target to pull_request and removed the
authorize step [\#796](#796)
([desusai7](https://github.com/desusai7))
- Bump @testing-library/react from 14.1.2 to 14.3.1
[\#757](#757)
([dependabot[bot]](https://github.com/apps/dependabot))
- Bump ts-jest from 29.1.1 to 29.1.5
[\#766](#766)
([dependabot[bot]](https://github.com/apps/dependabot))
- Bump cypress from 13.6.1 to 13.12.0
[\#770](#770)
([dependabot[bot]](https://github.com/apps/dependabot))
- Bump @types/jest from 29.5.11 to 29.5.12
[\#750](#750)
([dependabot[bot]](https://github.com/apps/dependabot))
- Bump @types/react from 18.2.45 to 18.2.64
[\#747](#747)
([dependabot[bot]](https://github.com/apps/dependabot))
- Bump browserstack-cypress-cli from 1.28.0 to 1.28.1
[\#715](#715)
([dependabot[bot]](https://github.com/apps/dependabot))

**Fixed**
- fix npm release workflow
[\#826](#826)
([tusharpandey13](https://github.com/tusharpandey13))
- Update codeowner file with new GitHub team name
[\#790](#790)
([stevenwong-okta](https://github.com/stevenwong-okta))
- Workaround for failing "integration test (CRA)"
[\#769](#769)
([nandan-bhat](https://github.com/nandan-bhat))

**Removed**
- Revert "Release v2.3.0"
[\#827](#827)
([tusharpandey13](https://github.com/tusharpandey13))

**Security**
- Bump pretty-quick from 3.1.3 to 3.3.1
[\#736](#736)
([dependabot[bot]](https://github.com/apps/dependabot))
- Bump next from 13.5.6 to 14.1.1 in /examples/nextjs-app
[\#761](#761)
([dependabot[bot]](https://github.com/apps/dependabot))
- Bump jose from 4.11.0 to 4.15.5 in /examples/users-api
[\#749](#749)
([dependabot[bot]](https://github.com/apps/dependabot))
- Bump express from 4.18.2 to 4.19.2 in /examples/users-api
[\#754](#754)
([dependabot[bot]](https://github.com/apps/dependabot))
- Bump follow-redirects from 1.15.3 to 1.15.6
[\#752](#752)
([dependabot[bot]](https://github.com/apps/dependabot))
- Bump ws from 7.5.9 to 7.5.10
[\#768](#768)
([dependabot[bot]](https://github.com/apps/dependabot))
- Bump braces from 3.0.2 to 3.0.3
[\#773](#773)
([dependabot[bot]](https://github.com/apps/dependabot))
- Bump oidc-provider from 8.4.3 to 8.4.5
[\#720](#720)
([dependabot[bot]](https://github.com/apps/dependabot))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants