Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow signup submit to make async requests before completing sign up #1748

Closed
bstaley opened this issue Nov 6, 2019 · 3 comments · Fixed by #1799
Closed

Allow signup submit to make async requests before completing sign up #1748

bstaley opened this issue Nov 6, 2019 · 3 comments · Fixed by #1799

Comments

@bstaley
Copy link
Contributor

bstaley commented Nov 6, 2019

Describe the problem you'd like to have solved

I would like to control when or if the signup submit continues

Describe the ideal solution

Ideally if you subscribe to signup submit using on the function would expect you to return a promise or an observable. That way i could perform some functions or requests and if they fail then stop the processing of the signup.

Alternatives and current work-arounds

Not sure of any ATM

Additional context

I am trying to add database generated info to the user_metadata before Auth0 processes the signup request. This information is then turned into a claim.

@bstaley
Copy link
Contributor Author

bstaley commented Nov 9, 2019

i have forked lock and committed a work around which emits 'signup success'. this will allow me sign up(auto log in disabled) -> get a notification from success -> make my calls -> have the user sign in with their newly created account with the correct claims. fyi, https://github.com/bstaley/lock

@stevehobbsdev
Copy link
Contributor

@bstaley Apologies for the time it has taken to pick this up. For the workaround, please feel free to submit your PR and we can look at getting it integrated. Thanks!

@bstaley
Copy link
Contributor Author

bstaley commented Feb 7, 2020

Looks like you guys were able to merge in some changes in late Nov. that included signup success. I have made a small change and submitted a PR for it #1799. Let me know if you see any issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants