Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return results with signup success callback #1799

Merged
merged 6 commits into from
Feb 14, 2020

Conversation

bstaley
Copy link
Contributor

@bstaley bstaley commented Feb 7, 2020

Changes

Added the results to the signup success callback. This is needed for persisting this data in client databases.

References

#1748

Testing

To test please use lock.on('signup success', (results) => { console.log(results); })

  • This change adds unit test coverage
  • This change adds integration test coverage
  • [x ] This change has been tested on the latest version of the platform/language

Checklist

  • [x ] I have read the Auth0 general contribution guidelines
  • [ x] I have read the Auth0 Code of Conduct
  • [x ] All existing and new tests complete without errors
  • [x ] All code quality tools/guidelines have been run/followed
  • [x ] All relevant assets have been compiled
  • [x ] All active GitHub checks have passed

@bstaley bstaley requested a review from a team February 7, 2020 01:17
@lbalmaceda
Copy link
Contributor

@bstaley thanks for the contribution. Please, update the PR title and description trying to follow the template. Someone will pick it up then.

@stevehobbsdev
Copy link
Contributor

@bstaley Has the new work here been submitted on top of another PR? The commits here don't seem to reflect the actual changes in the changeset.

As @lbalmaceda, the lack of a title and appropriate description make it hard to understand the context of the PR. Feel free to submit a fresh PR if that makes it easier to propose the change.

@bstaley
Copy link
Contributor Author

bstaley commented Feb 7, 2020

Yes, because my fork was behind and you guys already did most of the work the following would be the only real change

l.emitEvent(m, 'signup success', result);

I will go and modify the title and description.

@bstaley bstaley changed the title Auth0 master Return results with signup success callback Feb 7, 2020
@stevehobbsdev stevehobbsdev added this to the vNext milestone Feb 7, 2020
@stevehobbsdev stevehobbsdev self-assigned this Feb 7, 2020
@stevehobbsdev
Copy link
Contributor

@bstaley Thanks!

@stevehobbsdev stevehobbsdev merged commit cf34e88 into auth0:master Feb 14, 2020
jfromaniello pushed a commit to jfromaniello/auth0-lock that referenced this pull request Mar 5, 2020
* updated lock to have signup success

* updated version

* updated package name

* updated entity reference

* small readme fix
davidpatrick pushed a commit to davidpatrick/lock that referenced this pull request Jun 12, 2020
* updated lock to have signup success

* updated version

* updated package name

* updated entity reference

* small readme fix
jfromaniello pushed a commit to jfromaniello/auth0-lock that referenced this pull request Jul 23, 2020
* updated lock to have signup success

* updated version

* updated package name

* updated entity reference

* small readme fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow signup submit to make async requests before completing sign up
3 participants