Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

theme.logo regression in 10.3.0 #617

Closed
doapp-ryanp opened this issue Sep 21, 2016 · 0 comments
Closed

theme.logo regression in 10.3.0 #617

doapp-ryanp opened this issue Sep 21, 2016 · 0 comments
Assignees
@beneliflo
Labels
bug This points to a verified bug in the code
Milestone
v10.4.0

Comments

@doapp-ryanp
Copy link
Contributor

doapp-ryanp commented Sep 21, 2016 •
edited
Loading

Why was a fixed width added for theme.logo in fa64349 ? This broke existing logo's aspect ratio preservation. Could min-width: 50px be used instead?

In addition the logo docs state that recommendation is 58px however the css forces 55px. IMO 58px looks better, can the css for height be updated to be consistent with the docs?
doapp-ryanp pushed a commit to doapp-ryanp/lock that referenced this issue Sep 21, 2016
Fixes for 10.3.0 regression
52fe1a3 
Fixes auth0#617
@doapp-ryanp doapp-ryanp mentioned this issue Sep 21, 2016
Merged
@hzalaz hzalaz added bug This points to a verified bug in the code P3: Important and removed F1: inspection required labels Sep 26, 2016
hzalaz pushed a commit that referenced this issue Sep 27, 2016
@hzalaz
Fixes for 10.3.0 regression (#618)
02409e8 
Fixes #617
@hzalaz hzalaz modified the milestone: v10.4.0 Sep 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@beneliflo beneliflo

Labels
bug This points to a verified bug in the code
Projects
None yet
Milestone
v10.4.0
Development

No branches or pull requests
3 participants
@hzalaz @doapp-ryanp @beneliflo