Update username allowed chars regex #1079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For the future: the translation code needs async/await support, so you have to use nodejs 7.6+ |
lbalmaceda
reviewed
Aug 10, 2017
src/i18n/kr.js
Outdated
| password_leaked: '본 계정은 외부 접근으로 인한 회원 정보 유출이 우려되어, 보안 상의 문제로 비활성화되었습니다. 계정을 다시 활성화하는 방법은 자동 전송된 이메일에 안내되어 있습니다.', | ||
| too_many_attempts: '본 계정은 단시간에 복수의 로그인 시도가 감지되어 차단되었습니다.', | ||
| session_missing: '인증 요청이 완료되지 않았습니다. 열려있는 모든 다이얼로그 창을 닫고 다시 시도해 주시기 바랍니다.' | ||
| session_missing: '인증 요청이 완료되지 않았습니다. 열려있는 모든 다이얼로그 창을 닫고 다시 시도해 주시기 바랍니다.', | ||
| 'hrd.not_matching_email': 'Please, use your corporate email to login.' |
There was a problem hiding this comment.
This one is not korean 👎. The key seems to have quotes ' and that's somehow breaking the script?
There was a problem hiding this comment.
the key has quotes because it has a . in it, so you have to make it a string. I'll check what's going on.
src/i18n/kr.js
Outdated
| @@ -98,7 +101,7 @@ export default { | |||
| ssoEnabled: '통합 인증이 유효합니다.', | |||
| submitLabel: '전송', | |||
| unrecoverableError: '오류가 발생하였습니다.<br />고객센터로 연락하여 주시기 바랍니다.', | |||
| usernameFormatErrorHint: '%d-%d의 문자, 숫자, "_"이/가 사용 가능합니다.', | |||
| usernameFormatErrorHint: 'Use %d-%d letters, numbers and the following characters: "_", ".", "+", "-"', | |||
src/i18n/kr.js
Outdated
| @@ -109,5 +112,6 @@ export default { | |||
| mfaLoginTitle: '2단계 인증', | |||
| mfaLoginInstructions: '스마트폰 어플리케이션으로 생성된 확인 코드를 입력하여 주세요.', | |||
| mfaSubmitLabel: '로그인', | |||
| mfaCodeErrorHint: '%d 숫자를 사용하여 주세요.' | |||
| mfaCodeErrorHint: '%d 숫자를 사용하여 주세요.', | |||
| showPassword: 'Show password' | |||
| @@ -96,7 +96,7 @@ export default { | |||
| ssoEnabled: 'Single Sign-On habilitado', | |||
| submitLabel: 'Enviar', | |||
| unrecoverableError: 'Algo deu errado.<br />Por favor entre em contato com o suporte.', | |||
| usernameFormatErrorHint: 'Use %d-%d letras, números e "_"', | |||
| usernameFormatErrorHint: 'Use %d-%d letras, números e os seguintes caracteres: "_", ".", "+", "-"', | |||
luisrudge
force-pushed
the
fix-invalid-chars
branch
from
65825ef
to
362d36a
Compare
luisrudge
force-pushed
the
fix-invalid-chars
branch
from
362d36a
to
80a1fd2
Compare
lbalmaceda
approved these changes
Aug 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1072